sort introspection results #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the return value stable, which makes life easier for anyone calling it and using it as an input that becomes a cache key. Signed-off-by: Erik Sipsma <[email protected]>
jedevc
reviewed
Nov 3, 2023
introspection.go
Outdated
|
|
||
| "github.com/dagger/graphql/language/ast" | ||
| "github.com/dagger/graphql/language/printer" | ||
| "golang.org/x/exp/slices" |
There was a problem hiding this comment.
Looks like this either needs a go mod tidy or an upgrade of go version, so we can use https://pkg.go.dev/slices (which is now built-in to the stdlib 🎉)
jedevc
approved these changes
Nov 3, 2023
Signed-off-by: Erik Sipsma <[email protected]>
Signed-off-by: Erik Sipsma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the return value stable, which makes life easier for anyone calling it and using it as an input that becomes a cache key.
Fixing this in order to improve runtime for Zenith modules. We were invalidating cache of SDK calls too often due to this being unstable. One demo @kpenfound is working on previously took minimum ~25s every run; with this fix it goes down to ~8s.